Re: Regression tests fail with musl libc because libpq.so can't be loaded

From: walther(at)technowledgy(dot)de
To: Bruce Momjian <bruce(at)momjian(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: 2024-03-22 08:33:38
Message-ID: a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Bruce Momjian:
> I suggest we use the #ifdef test to continue our existing behavior for
> the libraries we know about, like glibc, and use the LD_* process title
> truncation hack for libc's we don't recognize.
>
> Attached is a prototype patch which implements this based on previous
> patches.

The condition to check for linux/glibc in your patch is slightly off:

#if ! defined(__linux__) || (! defined(__GLIBC__) &&
defined(__UCLIBC__ ))

should be

#if defined(__linux__) && ! (defined(__GLIBC__) || defined(__UCLIBC__ ))

With the latter, it passes tests with musl.

Best,

Wolfgang

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Richard Guo 2024-03-22 08:55:47 Re: BUG #18305: Unexpected error: "WindowFunc not found in subplan target lists" triggered by subqueries
Previous Message Tomas Vondra 2024-03-22 08:28:29 Re: Index plan returns different results to sequential scan

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-03-22 08:54:29 Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Previous Message jian he 2024-03-22 08:28:39 Re: Catalog domain not-null constraints