Re: check with serial

On 05/02/2017 10:13 PM, Vaishnavi Prabakaran wrote:
>
>
> On Tue, May 2, 2017 at 11:30 PM, Andrew Dunstan
> <andrew(dot)dunstan(at)2ndquadrant(dot)com
> <mailto:andrew(dot)dunstan(at)2ndquadrant(dot)com>> wrote:
>
>
> Here's a simple patch that does what I had in mind. It allows
> providing
> for an arbitrary schedule file in both the check and installcheck
> recipes. The historic behaviour is preserved.
>
>
> Hmm, installcheck command with SCHEDULE set as "Parallel" does not
> honor "MAXCONNOPT" settings in the attached patch.

good point.

>
> And, now after your patch, do we still need "installcheck-parallel"
> command? It is redundant IMO, just give a thought.

I'd be quite happy to remove the target in favor of this more general
solution.

Thoughts?

>
> Documentation changes("Running the Tests") are also required as the
> behavior documented is now changed in this patch.

Yes, agreed. Thanks for your comments.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services