| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding support for Default partition in partitioning |
| Date: | 2017-06-15 07:01:53 |
| Message-ID: | a1267081-6e9a-e570-f6cf-34ff801bf503@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Oops, I meant to send one more comment.
On 2017/06/15 15:48, Amit Langote wrote:
> BTW, I noticed the following in 0002
+ errmsg("there exists a default partition for table \"%s\", cannot
add a new partition",
This error message style seems novel to me. I'm not sure about the best
message text here, but maybe: "cannot add new partition to table \"%s\"
with default partition"
Note that the comment applies to both DefineRelation and
ATExecAttachPartition.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2017-06-15 07:08:10 | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Previous Message | Amit Langote | 2017-06-15 06:48:55 | Re: Adding support for Default partition in partitioning |