Re: Propagate XLogFindNextRecord error to callers

Hi Anthonin,

Thanks for the updated patch.

I have noticed this code added in XLogFindNextRecord in the patch,
appears also in XLogNextRecord (line 334).

> + if (state->errormsg_deferred)
> + {
> + if (state->errormsg_buf[0] != '\0')
> + *errormsg = state->errormsg_buf;
> + state->errormsg_deferred = false;
> + }
> +

In XLogNextRecord, right before the above code, we do *errormsg = NULL.
Should this be done also in XLogFindNextRecord in the patch?

If so, what about even extracting a helper method which will be called
from both places?

A nit for the commit message: Propage -> Propagate

--
Thanks,
Mircea Cadariu