Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates

From: Anders Kaseorg <andersk(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Sutou Kouhei <kou(at)clear-code(dot)com>
Subject: Re: PGroonga index-only scan problem with yesterday’s PostgreSQL updates
Date: 2022-02-12 20:36:26
Message-ID: a1192558-c880-54be-0bef-9e4ed8607061@mit.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/12/22 09:25, Tom Lane wrote:
> I don't know that we'd go that far ... maybe if another bad problem
> turns up. In the meantime, though, I do have a modest suggestion:
> it would not be too hard to put some defenses in place against another
> such bug. The faulty commit was in our tree for a month and nobody
> reported a problem, which is annoying. Do you want to think about doing
> your testing against git branch tips, rather than the last released
> versions? Making a new build every few days would probably be plenty
> fast enough.
>
> An even slicker answer would be to set up a PG buildfarm machine
> that, in addition to the basic tests, builds PGroonga against the
> new PG sources and runs your tests. Andrew's machine "crake" does
> that for RedisFDW and BlackholeFDW, and the source code for at least
> the latter module is in the buildfarm client distribution.

I’m a Zulip developer, not a PGroonga developer, but this sounds like a
good idea to me, so I opened a PR to add the PostgreSQL 15 snapshot
build to PGroonga’s test matrix.

https://github.com/pgroonga/pgroonga/pull/204

The current snapshot build in the PGDG APT repository is
15~~devel~20220208.0530-1~541.gitba15f16, predating this fix, despite
the documentation that they should be built every 6 hours
(https://wiki.postgresql.org/wiki/Apt/FAQ#Development_snapshots). But
it seems the tests have other failures against this snapshot build that
will need to be investigated.

Anders

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2022-02-12 20:44:32 Re: Use generation context to speed up tuplesorts
Previous Message Matheus Alcantara 2022-02-12 20:17:29 [PATCH] Add tests for psql tab completion