| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, John Naylor <johncnaylorls(at)gmail(dot)com> |
| Subject: | Re: Reorganize GUC structs |
| Date: | 2025-11-07 15:44:40 |
| Message-ID: | a0a31b01-2978-42ad-a21e-f21186472089@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.11.25 10:38, Álvaro Herrera wrote:
> On 2025-Nov-07, Peter Eisentraut wrote:
>
>> @@ -3135,14 +3135,14 @@ parse_and_validate_value(const struct config_generic *record,
>> char *hintmsg;
>>
>> hintmsg = config_enum_get_options(conf,
>> - "Available values: ",
>> - ".", ", ");
>> + _("Available values: "),
>> + _("."), _(", "));
>
> Hmm, it seems unclear (from the message catalog perspective) what the
> last two strings will be used for, so please add a /* translator */
> comment to each.
Actually, the ", " already exists in the message catalog, so adding a
comment here might confuse the other site.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-11-07 15:53:01 | Re: Some efforts to get rid of "long" in our codebase |
| Previous Message | Peter Eisentraut | 2025-11-07 15:39:42 | Re: Decouple C++ support in Meson's PGXS from LLVM enablement |