| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dmitry Mityugov <d(dot)mityugov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings |
| Date: | 2025-07-16 09:07:41 |
| Message-ID: | a094061a-525e-4d9e-88db-2035a933e0e8@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.07.25 01:35, Peter Geoghegan wrote:
> On Sat, Jul 12, 2025 at 1:55 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> I had played with using pg_assume here too, but I couldn't really convince
>> myself that it's a good idea...
>
> In the past, it was often necessary to work around MSVC's inability to
> see that a block containing elog(ERROR) doesn't actually need to
> initialize variables that'll never actually be used in code that comes
> after that block. We still have many "keep compiler quiet" variable
> initializations due to this.
>
> Is that still something that we need to worry about? I don't recall
> running into it in quite a few years, though that might just be a
> coincidence.
Yes, this continues to be an unsolved problem. See here for a recent
discussion:
https://www.postgresql.org/message-id/CAApHDvrFdXjbrV6KCx_GHKYSufUbNDYSsjppcJQiGOURfJE6qg@mail.gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2025-07-16 09:30:17 | Re: Improve pg_sync_replication_slots() to wait for primary to advance |
| Previous Message | John Naylor | 2025-07-16 09:02:46 | Re: Improving and extending int128.h to more of numeric.c |