Re: analyze-in-stages post upgrade questions

From: Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "Zechman, Derek S" <Derek(dot)S(dot)Zechman(at)snapon(dot)com>, Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, "pgsql-general(at)lists(dot)postgresql(dot)org" <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: analyze-in-stages post upgrade questions
Date: 2025-07-10 16:20:02
Message-ID: a018a729-9b18-444f-baed-be0d6d8ecb80@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Hi Laurenz,

Got it. I have only one suggestion for the patch. Consider adding a
corresponding test in src/bin/scripts/t/100_vacuumdb.pl.

Proposal (I used this to check the patch):

$node->safe_psql('postgres',
    "CREATE TABLE parent_table (a INT) PARTITION BY LIST (a);\n"
      . "CREATE TABLE child_table PARTITION OF parent_table FOR VALUES
IN (1);\n"
      . "INSERT INTO parent_table VALUES (1);\n");
$node->issues_sql_like(
    [
        'vacuumdb', '--analyze-only', 'postgres'
    ],
    qr/statement:\s+ANALYZE\s+public\.parent_table/s,
    '--analyze_only updates statistics for partitioned tables');

Kind regards,

Mircea Cadariu

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Adrian Klaver 2025-07-10 16:25:57 Re: Aggregate versions of hashing functions (md5, sha1, etc...)
Previous Message Tom Lane 2025-07-10 15:28:46 Re: Lock timeout in commit

Browse pgsql-hackers by date

  From Date Subject
Next Message Srirama Kucherlapati 2025-07-10 16:55:39 RE: Buildfarm setup for AIX
Previous Message Nathan Bossart 2025-07-10 16:03:06 Re: CHECKPOINT unlogged data