Re: WAL record CRC calculated incorrectly because of underlying buffer modification

From: Greg Burd <greg(at)burd(dot)me>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, pgsql(at)j-davis(dot)com, thomas(dot)munro(at)gmail(dot)com, exclusion(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com, hlinnaka(at)iki(dot)fi
Subject: Re: WAL record CRC calculated incorrectly because of underlying buffer modification
Date: 2026-10-27 14:32:00
Message-ID: _JqUuJV2GJ97lUMt7y373Se22diTaSiYnF86ncGnQSXjui-E9CEC8Cs_EuD-Wo_7PyNF9Bn6vGRoIIow5XiXhSmRK4JGomtrTJPkTi05DtI=@burd.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Tuesday, October 27th, 2026 at 10:05 AM, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> Hi Greg,
> > That's a signal to innovate, not remove code.
>
> I agree with that and I would like to spend some time to modernize hash,
> I will start looking after the PG19 release and happy to review any of your
> hash changes.

Sounds like a plan to me.

> > Expression indexes prevent HOT updates, so maybe you could but at what
> > cost?
>
> Haven't really tested that, just some wild thinking, but I think hash index also
> have similar limitations.

This is a heap limitation, and update to a row where there is an expression index
that has a column reference which was modified prevents the HOT update even if
that expression didn't result in a material change to the index key.

> Thanks,
> Shihao

-greg

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2026-10-27 14:33:35 Clean up code comments for pg_wchar_tbl
Previous Message Jakub Wartak 2026-10-27 14:27:56 Re: pg_*_advice: tsv load failure, etc.