Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, shveta(dot)malik(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Date: 2024-10-31 17:22:51
Message-ID: ZyO862SbhDpsoqB-@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 18, 2024 at 04:25:33PM +0530, Amit Kapila wrote:
> Few comments:
> =============
> 1.
> <para>
> - True if this slot is currently actively being used
> + True if this slot is currently currently being streamed
> </para></entry>
>
> currently shouldn't be used twice.
>
> 2.
> - /* The time since the slot has become inactive */
> + /* The time slot sychronized was stopped. */
> TimestampTz inactive_since;
>
> Would it be better to say: "The time slot synchronization was stopped."?
>
> 3.
> This is useful for slots on the
> + standby that are intended to be synced from a primary server
>
> I think it is better to be explicit here and probably say: "This is
> useful for slots on the standby that are being synced from a primary
> server .."

Agreed, fixed in the attached patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"

Attachment Content-Type Size
inactive.diff text/x-diff 3.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-10-31 17:25:33 Re: Use "protocol options" name instead of "protocol extensions" everywhere
Previous Message Aleksander Alekseev 2024-10-31 17:21:53 Re: "command cannot affect row a second time" in INSERT ... ON CONFLICT