| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: bug: copy progress reporting of backends which run multiple COPYs |
| Date: | 2024-05-07 12:27:54 |
| Message-ID: | ZjoeSq3mgYpl6Dhj@pryzbyj2023 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 21, 2023 at 02:45:40AM +0100, Matthias van de Meent wrote:
> > Would you do anything different in the master branch, with no
> > compatibility constraints ? I think the progress reporting would still
> > be limited to one row per backend, not one per CopyFrom().
>
> I think I would at least introduce another parameter to BeginCopyFrom
> for progress reporting (instead of relying on pstate != NULL), like
> how we have a bit in reindex_index's params->options that specifies
> whether we want progress reporting (which is unset for parallel
> workers iirc).
This didn't get fixed for v16, and it seems unlikely that it'll be
addressed in back branches.
But while I was reviewing forgotten threads, it occurred to me to raise
the issue in time to fix it for v17.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2024-05-07 12:28:58 | pg_restore -N loses extension comment |
| Previous Message | Amit Kapila | 2024-05-07 12:16:31 | Re: Control flow in logical replication walsender |