Re: pgsql: meson: Add initial version of meson based build system

From: Christoph Berg <myon(at)debian(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: meson: Add initial version of meson based build system
Date: 2024-04-18 08:54:18
Message-ID: ZiDful1M9pEhpno4@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Andres Freund
> > This commit broke VPATH builds when the original source directory
> > contains symlinks.
>
> I.e. a symlink to the source directory, not a symlink inside the source
> directory.

Yes.

> Argh, this is missing spaces around the '=', leading to the branch always
> being entered.

Glad I found at least something :)

> Uh, I don't think it does? Afaict this failure is entirely unrelated to 'touch
> meson.build'? From what I can tell the problem is that config/prep_buildtree
> is invoked with the symlinked path, and that that doesn't seem to work:

Apparently I messed up both the git bisect run and manually
confirm the problem later. Trying again now, the problem has been
existing at least since 2002, probably earlier.

I've been using this directory layout for years, apparently so far
I've always only used non-VPATH builds or dpkg-buildpackage, which
probably canonicalizes the path before building, given it works.

Since no one else has been complaining, it might not be worth fixing.

Sorry for the noise!

Christoph

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-04-18 09:37:16 pgsql: Update src/tools/pginclude/README to match recent changes to cpl
Previous Message Amit Langote 2024-04-18 08:31:47 pgsql: Fix object name clash in recently introduced test

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2024-04-18 08:54:45 Re: POC: GROUP BY optimization
Previous Message Peter Eisentraut 2024-04-18 08:50:05 Re: Support a wildcard in backtrace_functions