Re: Confusing #if nesting in hmac_openssl.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Confusing #if nesting in hmac_openssl.c
Date: 2024-04-03 06:18:10
Message-ID: Zgz0otnU_9nyVDLJ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 02, 2024 at 03:56:13PM +0200, Daniel Gustafsson wrote:
> > On 2 Apr 2024, at 15:50, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > I'll go ahead with what I have.
>
> +1

+#ifdef USE_RESOWNER_FOR_HMAC

Why not, that's cleaner. Thanks for the commit. The interactions
between this code and b8bff07da are interesting.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michał Kłeczek 2024-04-03 06:43:17 Is it safe to cache data by GiST consistent function
Previous Message Michael Paquier 2024-04-03 06:13:13 Re: Fix for timestamp lag issue from emit_log_hook when GUC log_line_prefix has '%m'