Re: Regression tests fail with musl libc because libpq.so can't be loaded

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: walther(at)technowledgy(dot)de
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: 2024-03-25 22:35:06
Message-ID: ZgH8GiD0CqYrTPQq@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Mar 25, 2024 at 10:58:30PM +0100, walther(at)technowledgy(dot)de wrote:
> Bruce Momjian:
> > With no one "hoping this patch dies in a fire"*, I have updated it with
> > more details, which I now think is committable to master. Is this
> > something to backpatch? Seems too rare a bug to me.
>
> I would like to see this backpatched to be able to run the regression tests
> easily on all stable branches.

You want to risk destabilizing Postgres by backpatching something this
complex so the regression tests can be run on all stable branches? I
think you are overestimating our desire to take on risk.

Also, in my patch, the parentheses here:

#if defined(__linux__) && (! defined(__GLIBC__) && ! defined(__UCLIBC__))

are unnecessary so they should be removed:

#if defined(__linux__) && ! defined(__GLIBC__) && ! defined(__UCLIBC__)

I am only willing to apply my patch, and only to master. Other
committers might be more willing.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2024-03-25 22:46:09 Re: Regression tests fail with musl libc because libpq.so can't be loaded
Previous Message walther 2024-03-25 21:58:30 Re: Regression tests fail with musl libc because libpq.so can't be loaded

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-03-25 22:46:09 Re: Regression tests fail with musl libc because libpq.so can't be loaded
Previous Message Jacob Champion 2024-03-25 22:14:52 Re: WIP Incremental JSON Parser