| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Autogenerate some wait events code and documentation |
| Date: | 2024-04-04 11:56:36 |
| Message-ID: | Zg6VdOGrJpVcG30v@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Apr 04, 2024 at 07:14:47PM +0900, Michael Paquier wrote:
> On Thu, Apr 04, 2024 at 09:28:36AM +0000, Bertrand Drouvot wrote:
> > +# No "Backpatch" region here as code is generated automatically.
> >
> > What about "....region here as has its own C code" (that would be more consistent
> > with the comment in the "header" for the file). Done that way in v4.
>
> I'd add a "as -this section- has its own C code", for clarity. This
> just looked a bit strange here.
Sounds good, done that way in v5 attached.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-ABI_compatibility-regions-in-wait_event_names.patch | text/x-diff | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-04-04 12:01:45 | Re: Synchronizing slots from primary to standby |
| Previous Message | Amit Kapila | 2024-04-04 11:46:49 | Re: promotion related handling in pg_sync_replication_slots() |