| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, jian(dot)universality(at)gmail(dot)com, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Add new error_action COPY ON_ERROR "log" |
| Date: | 2024-03-12 23:46:29 |
| Message-ID: | ZfDpVd_IIhvFhBsP@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 12, 2024 at 12:54:29PM +0530, Bharath Rupireddy wrote:
> +1. But, do you want to add them now or later as a separate
> patch/discussion altogether?
The attached 0003 is what I had in mind:
- Simplification of the LOG generated with quotes applied around the
column name, don't see much need to add the relation name, either, for
consistency and because the knowledge is known in the query.
- A few more tests.
- Some doc changes.
>> Wouldn't it be better to squash the patches together, by the way?
>
> I guess not. They are two different things IMV.
Well, 0001 is sitting doing nothing because the COPY code does not
make use of it internally.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-LOG_VERBOSITY-option-to-COPY-command.patch | text/x-diff | 9.5 KB |
| v6-0002-Add-detailed-info-when-COPY-skips-soft-errors.patch | text/x-diff | 4.9 KB |
| v6-0003-Some-docs-and-comments-updates.patch | text/x-diff | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sutou Kouhei | 2024-03-12 23:56:38 | Re: meson: Specify -Wformat as a common warning flag for extensions |
| Previous Message | Tom Lane | 2024-03-12 22:59:04 | Re: perl: unsafe empty pattern behavior |