| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, jian(dot)universality(at)gmail(dot)com, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Add new error_action COPY ON_ERROR "log" |
| Date: | 2024-03-12 07:24:29 |
| Message-ID: | CALj2ACW8c8zO0__+9jP1zZ0ZfAj_gcOUN336nD4NW4pPTc1YQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 12, 2024 at 12:22 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Mar 11, 2024 at 06:00:00PM +0530, Bharath Rupireddy wrote:
> > Please see the attached v6 patch set.
>
> I am tempted to tweak a few things in the docs, the comments and the
> tests (particularly adding more patterns for tuples that fail on
> conversion while it's clear that there are not enough attributes after
> the incorrect values), but that looks roughly OK.
+1. But, do you want to add them now or later as a separate
patch/discussion altogether?
> Wouldn't it be better to squash the patches together, by the way?
I guess not. They are two different things IMV.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-03-12 07:54:16 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Michael Paquier | 2024-03-12 06:52:01 | Re: Add new error_action COPY ON_ERROR "log" |