Re: Fix race condition in InvalidatePossiblyObsoleteSlot()

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, exclusion(at)gmail(dot)com
Subject: Re: Fix race condition in InvalidatePossiblyObsoleteSlot()
Date: 2024-03-06 09:17:58
Message-ID: Zeg0xjF7dR6Bczk0@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Mar 06, 2024 at 02:47:55PM +0900, Michael Paquier wrote:
> On Tue, Mar 05, 2024 at 10:17:03AM +0000, Bertrand Drouvot wrote:
> > On Tue, Mar 05, 2024 at 09:42:20AM +0900, Michael Paquier wrote:
> > The issue is that then the new ASSERT is
> > triggered leading to the standby shutdown. So, I'm not sure how to improve this
> > case.
>
> It's been mentioned recently that we are not good at detecting crashes
> in the TAP tests. I am wondering if we should check the status of the
> node in the most popular routines of Cluster.pm and die hard, as one
> way to make the tests more responsive.. A topic for a different
> thread, for sure.

Right, somehow out of context here.

> > Done in v2.
>
> Reworded a few things and applied this version.

Thanks!

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-03-06 09:19:41 Re: Injection points: some tools to wait and wake
Previous Message Bharath Rupireddy 2024-03-06 09:16:57 Re: Introduce XID age and inactive timeout based replication slot invalidation