| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-02-28 03:59:24 |
| Message-ID: | Zd6vnEyXTyZcewgS@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 28, 2024 at 09:41:42AM +0800, Japin Li wrote:
> On Wed, 28 Feb 2024 at 00:06, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>> Attached is v5 of the patchset that also includes this change (with
>> you listed as author).
>
> Thanks for updating the patch!
Cool. I have applied 0004 and most of 0002. Attached is what
remains, where I am wondering if it would be cleaner to do these bits
together (did not look at the whole, yet).
> It looks good to me except there is an outdated comment.
Yep, I've updated that in the attached for now.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0002-Use-designated-initializer-syntax-to-improve-read.patch | text/x-diff | 19.4 KB |
| v6-0003-Simplify-pg_enc2gettext_tbl.patch | text/x-diff | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-02-28 04:02:40 | Re: Bytea PL/Perl transform |
| Previous Message | Noah Misch | 2024-02-28 03:52:59 | Re: Relation bulk write facility |