From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Subject: | Re: Synchronizing slots from primary to standby |
Date: | 2024-02-15 17:18:51 |
Message-ID: | Zc5He6laSZ/hAxB0@ip-10-97-1-34.eu-west-3.compute.internal |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Thu, Feb 15, 2024 at 06:13:38PM +0530, Amit Kapila wrote:
> On Thu, Feb 15, 2024 at 12:07 PM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Since the slotsync function is committed, I rebased remaining patches.
> > And here is the V88 patch set.
> >
Thanks!
>
> Please find the improvements in some of the comments in v88_0001*
> attached. Kindly include these in next version, if you are okay with
> it.
Looking at v88_0001, random comments:
1 ===
Commit message "Be enabling slot synchronization"
Typo? s:Be/By
2 ===
+ It enables a physical standby to synchronize logical failover slots
+ from the primary server so that logical subscribers are not blocked
+ after failover.
Not sure "not blocked" is the right wording.
"can be resumed from the new primary" maybe? (was discussed in [1])
3 ===
+#define SlotSyncWorkerAllowed() \
+ (sync_replication_slots && pmState == PM_HOT_STANDBY && \
+ SlotSyncWorkerCanRestart())
Maybe add a comment above the macro explaining the logic?
4 ===
+#include "replication/walreceiver.h"
#include "replication/slotsync.h"
should be reverse order?
5 ===
+ if (SlotSyncWorker->syncing)
{
- SpinLockRelease(&SlotSyncCtx->mutex);
+ SpinLockRelease(&SlotSyncWorker->mutex);
ereport(ERROR,
errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("cannot synchronize replication slots concurrently"));
}
worth to add a test in 040_standby_failover_slots_sync.pl for it?
6 ===
+static void
+slotsync_reread_config(bool restart)
+{
worth to add test(s) in 040_standby_failover_slots_sync.pl for it?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Bertrand Drouvot | 2024-02-15 17:24:23 | Re: Synchronizing slots from primary to standby |
Previous Message | Tomas Vondra | 2024-02-15 16:56:15 | Re: planner chooses incremental but not the best one |