Re: introduce dynamic shared memory registry

From: Abhijit Menon-Sen <ams(at)toroid(dot)org>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: introduce dynamic shared memory registry
Date: 2024-01-12 17:43:46
Message-ID: ZaF6UpYImGqVIhVp@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2024-01-12 11:21:52 -0600, nathandbossart(at)gmail(dot)com wrote:
>
> From: Nathan Bossart <nathan(at)postgresql(dot)org>
> Date: Thu, 11 Jan 2024 21:55:25 -0600
> Subject: [PATCH v6 1/3] reorganize shared memory and lwlocks documentation
>
> ---
> doc/src/sgml/xfunc.sgml | 182 +++++++++++++++++++++++++---------------
> 1 file changed, 114 insertions(+), 68 deletions(-)
>
> diff --git a/doc/src/sgml/xfunc.sgml b/doc/src/sgml/xfunc.sgml
> index 89116ae74c..0ba52b41d4 100644
> --- a/doc/src/sgml/xfunc.sgml
> +++ b/doc/src/sgml/xfunc.sgml
> @@ -3397,90 +3397,136 @@ CREATE FUNCTION make_array(anyelement) RETURNS anyarray
> </sect2>
>
> […]
> - from your <literal>shmem_request_hook</literal>.
> - </para>
> - <para>
> - LWLocks are reserved by calling:
> + Each backend sould obtain a pointer to the reserved shared memory by

sould → should

> + Add-ins can reserve LWLocks on server startup. Like with shared memory,

(Would "As with shared memory" read better? Maybe, but then again maybe
it should be left alone because you also write "Unlike with" elsewhere.)

-- Abhijit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2024-01-12 18:00:28 Re: Built-in CTYPE provider
Previous Message Melanie Plageman 2024-01-12 17:33:28 Re: Emit fewer vacuum records by reaping removable tuples during pruning