Re: Add \syncpipeline command to pgbench

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add \syncpipeline command to pgbench
Date: 2024-01-23 04:08:24
Message-ID: Za87uEUDqy_ttTsI@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 22, 2024 at 01:59:00PM +0100, Alvaro Herrera wrote:
> On 2024-Jan-22, Anthonin Bonnefoy wrote:
>> 0002 adds the \syncpipeline command (original patch with an additional
>> test case).
>
> I can look into this one later, unless Michael wants to.

The patch seemed rather OK at quick glance as long as there is a test
to check for error path with a \syncpipeline still on the stack of
metacommands to handle.
Anyway, I wanted to study this one and learn a bit more about the
error stuff that was happening on pgbench side. Now, if you feel
strongly about it, please go ahead!
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2024-01-23 04:13:56 Re: Make mesage at end-of-recovery less scary.
Previous Message Jeff Davis 2024-01-23 04:07:03 Re: Improve WALRead() to suck data directly from WAL buffers when possible