| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathan(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Prevent redeclaration of typedef TocEntry. |
| Date: | 2025-04-05 13:13:12 |
| Message-ID: | Z_EsaH5Mt4BYINTQ@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Sorry, I missed this one last night.
On Sat, Apr 05, 2025 at 02:10:10AM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>> ... AFAICS we could move both DefnDumperPtr and
>> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct
>> _tocEntry (the only place where they are used), and we'd have less of a
>> mess here. Then we don't need struct TocEntry in pg_backup.h anymore.
>
> +1 for this simplification.
This is a better fix. Thanks for taking care of it.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-04-05 16:14:31 | pgsql: Avoid double transformation of json_array()'s subquery. |
| Previous Message | Andrew Dunstan | 2025-04-05 12:03:01 | pgsql: Clean up from commit 1495eff7bdb |