| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: verify predefined LWLocks have entries in wait_event_names.txt |
| Date: | 2024-01-08 07:59:10 |
| Message-ID: | ZZurTpDvwMJO1EDV@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Sat, Jan 06, 2024 at 10:18:52AM -0600, Nathan Bossart wrote:
> On Sat, Jan 06, 2024 at 09:03:52AM +0000, Bertrand Drouvot wrote:
> > Sorry, I missed this in my first review, but instead of:
> >
> > - input: files('../../backend/storage/lmgr/lwlocknames.txt'),
> > + input: [files('../../backend/storage/lmgr/lwlocknames.txt'), files('../../backend/utils/activity/wait_event_names.txt')],
> >
> > what about?
> >
> > input: files(
> > '../../backend/storage/lmgr/lwlocknames.txt',
> > '../../backend/utils/activity/wait_event_names.txt',
> > ),
> >
> > It's done that way in doc/src/sgml/meson.build for example.
>
> I fixed this in v4.
Thanks!
+ input: [files(
+ '../../backend/storage/lmgr/lwlocknames.txt',
+ '../../backend/utils/activity/wait_event_names.txt')],
I think the "[" and "]" are not needed here.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wilma Wantren | 2024-01-08 08:05:47 | Changing a schema's name with function1 calling function2 |
| Previous Message | Bertrand Drouvot | 2024-01-08 07:34:48 | Re: Add a perl function in Cluster.pm to generate WAL |