Re: verify predefined LWLocks have entries in wait_event_names.txt

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: verify predefined LWLocks have entries in wait_event_names.txt
Date: 2024-01-03 02:34:25
Message-ID: ZZTHsd8-_L76GJ_a@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 02, 2024 at 11:31:20AM -0600, Nathan Bossart wrote:
> +# Find the location of lwlocknames.h.
> +my $include_dir = $node->config_data('--includedir');
> +my $lwlocknames_file = "$include_dir/server/storage/lwlocknames.h";

I am afraid that this is incorrect because an installation could
decide to install server-side headers in a different path than
$include/server/. Using --includedir-server would be the correct
answer, appending "storage/lwlocknames.h" to the path retrieved from
pg_config.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-01-03 03:23:44 Re: Track in pg_replication_slots the reason why slots conflict?
Previous Message David Rowley 2024-01-03 02:02:02 Re: Reducing output size of nodeToString