Re: Remove unneeded PGDATABASE setting from TAP tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove unneeded PGDATABASE setting from TAP tests
Date: 2023-12-31 03:06:40
Message-ID: ZZDawEZbko5asmoi@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote:
> Some of the TAP tests are explicitly setting PGDATABASE environment
> variable to 'postgres', which isn't needed because the TAP test's perl
> library PostgreSQL::Test::Cluster already sets it once and for all.
> I've attached a patch that removes all such unneeded PGDATABASE
> settings.
>
> Thoughts?

Hmm. I don't see any reason to not do that as these are not really
self-documenting either. How about 011_clusterdb_all.pl for
PGDATABASE?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias Kuhn 2023-12-31 05:08:04 Build versionless .so for Android
Previous Message Michael Paquier 2023-12-31 03:03:41 Re: Exclude generated wait_event files from pgindent