Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
Date: 2023-12-20 01:01:16
Message-ID: ZYI83OBanVOfOHVr@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote:
> Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
>
> This makes it possible for the code to be easily reused by other
> client-side tools, and/or by the server.
>
> Patch by me. Review of this patch in particular by at least Peter
> Eisentraut; reviewers for the patch series in general include Dilip
> Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.

Worth noting that this has forgotten to update @pgcommonallfiles in
Mkvcbuild.pm so this would have failed a build with src/build/msvc/.
Or you counted on me here, relying on the scripts to be gone? ;p
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2023-12-20 01:44:29 pgsql: Additional write barrier in AdvanceXLInsertBuffer().
Previous Message Michael Paquier 2023-12-20 00:45:45 pgsql: Remove MSVC scripts

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-12-20 01:14:55 Re: Remove MSVC scripts from the tree
Previous Message Michael Paquier 2023-12-20 00:48:37 Re: Remove MSVC scripts from the tree