| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | hlinnaka(at)iki(dot)fi, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Bogus WAL segments archived after promotion |
| Date: | 2023-11-25 15:48:53 |
| Message-ID: | ZWIXZbRlKUBGsXSA@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 23, 2015 at 02:57:59PM +0900, Michael Paquier wrote:
> Finally looking at that... The commit log of b2a5545 is a bit
> misleading. Segment files that were recycled during archive recovery
> are not necessarily removed, they could be recycled as well during
> promotion on the new timeline in line with what RemoveOldXlogFiles()
> does. Hence I think that the comment on top of
> RemoveNonParentXlogFiles() should be updated to reflect that like in
> the patch attached.
>
> Something minor: perhaps we could refactor xlogarchive.c to have
> XLogArchiveCheckDone() and XLogArchiveIsBusy() use the new
> XLogArchiveIsReady().
> Regards,
Old patch, but still valid, so applied to master, thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-11-25 16:13:18 | Re: POC, WIP: OR-clause support for indexes |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-11-25 15:19:22 | RE: Random pg_upgrade test failure on drongo |