| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, boekewurm+postgres(at)gmail(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com |
| Subject: | Re: Add new option 'all' to pg_stat_reset_shared() |
| Date: | 2023-11-15 00:47:03 |
| Message-ID: | ZVQVBx49A9Phfw9A@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 14, 2023 at 10:02:32PM +0900, torikoshia wrote:
> Attached patch.
You have forgotten to update the errhint at the end of
pg_stat_reset_shared(), where "slru" needs to be listed :)
> BTW currently the documentation explains all the arguments of
> pg_stat_reset_shared() in one line and I feel it's a bit hard to read.
> Attached patch uses <itemizedlist>.
Yes, this one is a good idea because each target works on a different
system view so it becomes easier to understand what a target affects,
so I've applied this bit, without the slru addition.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-11-15 00:58:10 | Re: Tab completion for CREATE TABLE ... AS |
| Previous Message | Andres Freund | 2023-11-15 00:30:24 | Re: meson documentation build open issues |