From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, boekewurm+postgres(at)gmail(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add new option 'all' to pg_stat_reset_shared() |
Date: | 2023-11-13 10:31:41 |
Message-ID: | ZVH7DSgIav5FxM14@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Nov 13, 2023 at 02:07:21PM +0530, Bharath Rupireddy wrote:
> Modified the docs for pg_stat_reset_slru to match with that of
> pg_stat_reset_shared. PSA v2 patch.
That feels consistent. Thanks.
> I noticed that the commit 23c8c0c8 missed to add proargnames =>
> '{target}' in .dat file for pg_stat_reset_shared, is it intentional?
> Naming the argument in system_funtion.sql is enough to be able to pass
> in named arguments like SELECT pg_stat_reset_shared(target := 'io');,
> but is it needed in .dat file as well to keep it consistent?
I don't see a need to do that because, as you say, the functions are
redefined for their default values, meaning that they'll also have
argument names consistent with the docs. There are quite a few like
that in pg_proc.dat like pg_promote, pg_backup_start,
json_populate_record, etc.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-11-13 10:32:27 | Re: pg_upgrade and logical replication |
Previous Message | Erik Wienhold | 2023-11-13 10:27:04 | Re: Fix output of zero privileges in psql |