Re: pgsql: Don't trust unvalidated xl_tot_len.

From: Christoph Berg <myon(at)debian(dot)org>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Date: 2023-11-11 11:53:37
Message-ID: ZU9rQYbAenlvgpsg@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Thomas Munro
> In the 13 branch we see that's in the new scan_server_header()
> subroutine where it tries to open the header, after asking pg_config
> --includedir-server where it lives. Hmm...

It's no ok to use pg_config at test time since `make install` might
not have been called yet:

https://www.postgresql.org/message-id/2023925.1644591595@sss.pgh.pa.us
https://www.postgresql.org/message-id/YqkV/hoi2SX91it8(at)paquier(dot)xyz

Christoph

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2023-11-11 18:17:02 Re: pgsql: Don't trust unvalidated xl_tot_len.
Previous Message Thomas Munro 2023-11-10 22:05:48 Re: pgsql: Don't trust unvalidated xl_tot_len.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2023-11-11 12:00:00 Re: ResourceOwner refactoring
Previous Message Sergei Kornilov 2023-11-11 10:43:47 Re:Making auto_explain more useful / convenient