| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Tab completion for AT TIME ZONE |
| Date: | 2023-10-13 05:31:22 |
| Message-ID: | ZSjWKqaIZqX8dsAK@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 13, 2023 at 03:07:25AM +0200, Vik Fearing wrote:
> The SQL committee already has another operator starting with AT which is AT
> LOCAL.
The other patch was the reason why I looked at this one. At the end,
I've made peace with Dagfinn's argument two messages ago, and applied
the patch after adding LOCAL to the keywords, but after also removing
the completion for "ZONE" after typing "AT TIME" because AT would be
completed by "TIME ZONE".
> I am implementing it in https://commitfest.postgresql.org/45/4343/
> where I humbly admit that I did not think of psql tab completion at all.
psql completion is always nice to have but not really mandatory IMO,
so leaving it out if one does not want to implement it is fine by me
to not complicate a patch. Completion could always be tackled on top
of any feature related to it that got committed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-10-13 05:36:54 | Re: pg_upgrade's interaction with pg_resetwal seems confusing |
| Previous Message | Michael Paquier | 2023-10-13 05:07:27 | Re: Add support for AT LOCAL |