From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag |
Date: | 2023-10-10 23:26:42 |
Message-ID: | ZSXdsqU0QlhYrw-r@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 10, 2023 at 09:12:49AM +0200, Drouvot, Bertrand wrote:
> On 10/10/23 7:58 AM, Michael Paquier wrote:
>> I was looking at v8 just before you sent this v9, and still got
>> annoyed by the extra boolean argument added to InitPostgres().
>
> Arf, I did not look at it as I had in mind to look at it once
> this one is in.
No problem. I'm OK to do it.
>> So
>> please let me propose to bite the bullet and refactor that, as of the
>> 0001 attached that means less diff footprints in all the callers of
>> InitPostgres() (I am not wedded to the flag names).
>
> Thanks for having looked at it!
>
> + bits32 init_flags = 0; /* never honor session_preload_libraries */
>
> Also a few word about datallowconn in the comment? (as the flag deals with both).
I am not sure that this is necessary in the code paths of
BackgroundWorkerInitializeConnectionByOid() and
BackgroundWorkerInitializeConnection() as datallowconn is handled a
few lines down.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-10-10 23:29:33 | Re: Lowering the default wal_blocksize to 4K |
Previous Message | Jean-Christophe Arnu | 2023-10-10 21:42:57 | Re: FDW pushdown of non-collated functions |