Re: document the need to analyze partitioned tables

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, yuzuko <yuzukohosoya(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: document the need to analyze partitioned tables
Date: 2023-10-06 16:20:30
Message-ID: ZSAzznpXcQZeW9uG@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 2, 2023 at 04:48:20AM +0200, Laurenz Albe wrote:
> On Fri, 2023-09-29 at 22:34 -0400, Bruce Momjian wrote:
> > Very good point! Updated patch attached.
>
> Thanks! Some small corrections:
>
> > diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml
> > index 9cf9d030a8..be1c522575 100644
> > --- a/doc/src/sgml/maintenance.sgml
> > +++ b/doc/src/sgml/maintenance.sgml
> > @@ -861,10 +861,16 @@ analyze threshold = analyze base threshold + analyze scale factor * number of tu
> >     </para>
> >  
> >     <para>
> > - Partitioned tables are not processed by autovacuum. Statistics
> > - should be collected by running a manual <command>ANALYZE</command> when it is
> > - first populated, and again whenever the distribution of data in its
> > - partitions changes significantly.
> > + Partitioned tables do not directly store tuples and consequently
> > + autovacuum does not <command>VACUUM</command> them. (Autovacuum does
>
> ... does not <command>VACUUM</command> or <command>ANALYZE</command> them.
>
> Perhaps it would be shorter to say "does not process them" like the
> original wording.
>
> > + perform <command>VACUUM</command> on table partitions just like other
>
> Just like *on* other tables, right?

Good points, updated patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Attachment Content-Type Size
autovacuum.diff text/x-diff 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-10-06 16:48:25 Re: Synchronizing slots from primary to standby
Previous Message Michał Kłeczek 2023-10-06 16:02:58 FDW LIM IT pushdown