Re: Add support for AT LOCAL

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, cary huang <hcary328(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add support for AT LOCAL
Date: 2023-10-17 06:25:14
Message-ID: ZS4oykeg1ydoTM0W@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 17, 2023 at 01:40:18AM -0400, Tom Lane wrote:
> makes the failure go away. Unfortunately, I've not yet found another
> way to make it go away :-(. My upthread idea of using a local variable
> instead of result->time is no help, and some other random code
> alterations didn't change the results either.

That may be a long shot, but even a modulo? Say in these two code
paths:
- while (result->time >= USECS_PER_DAY)
- result->time -= USECS_PER_DAY;
+ if (result->time >= USECS_PER_DAY)
+ result->time %= USECS_PER_DAY;

> Not sure where we go from here. While I don't have much hesitation
> about blowing off xlc_r 12.1, it would be sad if their latest
> toolchain doesn't work either. (I didn't try permuting the code
> while using the newer compiler, though.)

We've spent a lot of time on that. I'm OK to just give up, trim the
values of the view with a qual, and call it a day.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-10-17 06:27:33 Re: pg_logical_emit_message() misses a XLogFlush()
Previous Message Donghang Lin 2023-10-17 06:21:20 Re: interval_ops shall stop using btequalimage (deduplication)