Re: Could not run script when update unicode

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Could not run script when update unicode
Date: 2023-09-27 00:03:19
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Sep 26, 2023 at 10:43:40AM +0800, Japin Li wrote:
> # Allow running this even without --with-python
> PYTHON ?= python
> $(srcdir)/unaccent.rules: ../../src/common/unicode/UnicodeData.txt Latin-ASCII.xml
> $(PYTHON) $< --unicode-data-file $(word 2,$^) --latin-ascii-file $(word 3,$^) >$@
> It use python to run, However, the ?= operator in
> Makefile only check variable is defined or not, but do not check variable is
> empty. Since the PYTHON is defined in src/, so here PYTHON
> get empty when without --with-ptyhon.

I am not sure that many people run this script frequently so that may
not be worth adding a check for a defined, still empty or incorrect
value, but.. If you were to change the Makefile we use in this path,
how are you suggesting to change it?

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-09-27 00:37:36 Re: Annoying build warnings from latest Apple toolchain
Previous Message Michael Paquier 2023-09-26 23:51:26 Re: XLog size reductions: Reduced XLog record header size for PG17