Re: GUC for temporarily disabling event triggers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: GUC for temporarily disabling event triggers
Date: 2023-09-24 23:35:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Sep 22, 2023 at 05:29:01PM +0200, Daniel Gustafsson wrote:
> Since the main driver for this is to reduce the usage/need for single-user mode
> I also reworded the patch slightly. Instead of phrasing this as an alternative
> to single-user mode, I reversed it such that single-user mode is an alternative
> to this GUC.


+ be disabled by setting it to <literal>false</literal>. Setting the value
+ to <literal>true</literal> will not disable any event triggers, this

This uses a double negation. Perhaps just "Setting this value to true
allows all event triggers to run." has detected a failure because event_triggers is
missing in postgresql.conf.sample while it is not marked with

Keeping the docs consistent with the sample file, I would suggest the
attached on top of your v9.

Attachment Content-Type Size
v9-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch text/x-diff 9.1 KB
v9-0002-Fix-failure-in-TAP-tests.patch text/x-diff 734 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-25 00:00:51 Re: Fix bug in VACUUM and ANALYZE docs
Previous Message Karl O. Pinc 2023-09-24 23:30:32 Re: Fix bug in VACUUM and ANALYZE docs