Re: Parallel copy

From: "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, vignesh C <vignesh21(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Parallel copy
Date: 2020-10-29 08:56:39
Message-ID: ZR0P278MB010570202502E5F0F0E5FC3ED2140@ZR0P278MB0105.CHEP278.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27/10/2020 15:36, vignesh C wrote:
>> Attached v9 patches have the fixes for the above comments.

>I did some testing:

I did some testing as well and have a cosmetic remark:

postgres=# copy t1 from '/var/tmp/aa.txt' with (parallel 1000000000);
ERROR: value 1000000000 out of bounds for option "parallel"
DETAIL: Valid values are between "1" and "1024".
postgres=# copy t1 from '/var/tmp/aa.txt' with (parallel 100000000000);
ERROR: parallel requires an integer value
postgres=#

Wouldn't it make more sense to only have one error message? The first one seems to be the better message.

Regards
Daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message osumi.takamichi@fujitsu.com 2020-10-29 09:00:58 RE: extension patch of CREATE OR REPLACE TRIGGER
Previous Message Heikki Linnakangas 2020-10-29 08:50:44 Re: Parallel copy