Re: pg_upgrade and logical replication

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: pg_upgrade and logical replication
Date: 2023-09-19 06:19:29
Message-ID: ZQk9cdX2cGoyx5Wl@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 15, 2023 at 04:51:57PM +0530, vignesh C wrote:
> Another approach to solve this as suggested by one of my colleague
> Hou-san would be to set max_logical_replication_workers = 0 while
> upgrading. I will evaluate this and update the next version of patch
> accordingly.

In the context of an upgrade, any node started is isolated with its
own port and a custom unix domain directory with connections allowed
only through this one.

Saying that, I don't see why forcing max_logical_replication_workers
to be 0 would be necessarily a bad thing to prevent unnecessary
activity on the backend. This should be a separate patch built on
top of the main one, IMO.

Looking forward to seeing the rebased version you've mentioned, btw ;)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryoga Yoshida 2023-09-19 06:29:11 Re: Bug fix for psql's meta-command \ev
Previous Message Hayato Kuroda (Fujitsu) 2023-09-19 06:17:45 RE: [PoC] pg_upgrade: allow to upgrade publisher node