On Wed, Sep 13, 2023 at 02:02:47PM +0200, Daniel Gustafsson wrote:
> It might be worth concatenating the errmsg() while there since we typically
> don't linebreak errmsg strings anymore for greppability:
>
> - errmsg("could not write to log file %s "
> - "at offset %u, length %zu: %m",
> + errmsg("could not write to log file \"%s\" at offset %u, length %zu: %m",
>
> I don't have strong feelings wrt that, just have a vague memory of "concatenate
> when touching" as an informal guideline.
Because these are slightly easier to grep when looking for a given
pattern in the tree.
(I'm OK with your patch as well, FWIW.)
--
Michael