| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17928: Standby fails to decode WAL on termination of primary |
| Date: | 2023-09-05 03:19:46 |
| Message-ID: | ZPaeUimGAzhYVEn9@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Sep 04, 2023 at 07:43:59PM +1200, Thomas Munro wrote:
> I am behind on several things, so if you want to, please go ahead! I
> already posted a 15 version and a master version (which should also
> apply and work on 16), so we'd need 12, 13, 14.
And here you go for all the three branches, with all the tests
passing. This change is complicated enough that it would be better to
get more eyes on the three patches for these specific branches. Now,
this is much simpler since we don't have to worry about the
prefetching.
For these versions, it struck me that we *require* 6860198 so as the
header validation is able to correctly happen across page reads when
doing crash recovery. I have added this change in the patches
attached for simplicity, but 6860198 should be applied first on 12~14
as an independent change. I can do that as a first step, if you are
OK with that.
I haven't taken the time to rewrite the commit message yet for the
main patch ;p
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Don-t-trust-unvalidated-xl_tot_len.backpatch12 | text/plain | 23.5 KB |
| v5-0001-Don-t-trust-unvalidated-xl_tot_len.backpatch13 | text/plain | 23.5 KB |
| v5-0001-Don-t-trust-unvalidated-xl_tot_len.backpatch14 | text/plain | 23.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-09-05 03:58:42 | Re: BUG #17928: Standby fails to decode WAL on termination of primary |
| Previous Message | Richard Guo | 2023-09-05 02:37:33 | Re: BUG #18077: PostgreSQL server subprocess crashed by a SELECT statement with WITH clause |