Re: BUG #17928: Standby fails to decode WAL on termination of primary

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Sergei Kornilov <sk(at)zsrv(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Date: 2023-09-05 03:58:42
Message-ID: CA+hUKGJV1Ow_S86Fj25J_orojXkn4WPeARyY8-Xr88c85rJHEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Sep 5, 2023 at 3:19 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> And here you go for all the three branches, with all the tests
> passing. This change is complicated enough that it would be better to
> get more eyes on the three patches for these specific branches. Now,
> this is much simpler since we don't have to worry about the
> prefetching.

Thanks! Yeah.

> For these versions, it struck me that we *require* 6860198 so as the
> header validation is able to correctly happen across page reads when
> doing crash recovery. I have added this change in the patches
> attached for simplicity, but 6860198 should be applied first on 12~14
> as an independent change. I can do that as a first step, if you are
> OK with that.

Ahhhh, that explains why back-patching was unexpectedly unsuccessful
when I tried it. I have added Fujii-san to the CC list. I don't see
any problem with that plan but it would be good to hear from him.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2023-09-05 04:13:16 Re: BUG #17928: Standby fails to decode WAL on termination of primary
Previous Message Michael Paquier 2023-09-05 03:19:46 Re: BUG #17928: Standby fails to decode WAL on termination of primary