Re: pg_logical_emit_message() misses a XLogFlush()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_logical_emit_message() misses a XLogFlush()
Date: 2023-09-11 07:24:58
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Sep 11, 2023 at 02:42:16PM +0900, bt23nguyent wrote:
> A minor issue with the description here is that while the description for
> the new flush argument in pg_logical_emit_message() with bytea type is
> clearly declared, there is no description of flush argument in the former
> pg_logical_emit_message() with text type at all.

Indeed, I forgot to update the first function signature. Fixed in the

> On a side note, could you also include a bit more information that "flush is
> set to false by default" in the document as well? It could be helpful for
> the users.

With the function signature saying that, that did not seem stricly
necessary to me, but no objections to add a few words about that.

I'll need a bit more input from Fujii-san before doing anything about
his comments, still it looks like a doc issue to me that may need a
backpatch to clarify how the non-transactional case behaves.

Attaching a v4 with the two doc changes, fow now.

Attachment Content-Type Size
v4-0001-Add-flush-argument-to-pg_logical_emit_message.patch text/x-diff 8.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Lepikhov Andrei 2023-09-11 08:04:22 Re: MergeJoin beats HashJoin in the case of multiple hash clauses
Previous Message Jelte Fennema 2023-09-11 07:04:22 Re: PSQL error: total cell count of XXX exceeded