Re: PSQL error: total cell count of XXX exceeded

From: Jelte Fennema <postgres(at)jeltef(dot)nl>
To: Hongxu Ma <interma(at)outlook(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PSQL error: total cell count of XXX exceeded
Date: 2023-09-11 07:04:22
Message-ID: CAGECzQSo0qk+QwzVgGhjx+-gGmj41w+JPmUHmdeObFCp1h7pjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 11 Sept 2023 at 08:51, Hongxu Ma <interma(at)outlook(dot)com> wrote:
>
> I created a patch to fix it.
> Really appreciate to anyone can help to review it.
> Thanks.

I think "product" as a variable name isn't very descriptive. Let's
call it total_cells (or something similar instead).

Other than that I think it's a good change. content->cellsadded is
also a long, So I agree that I don't think the limit of int cells was
intended here.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-11 07:24:58 Re: pg_logical_emit_message() misses a XLogFlush()
Previous Message Amit Kapila 2023-09-11 06:53:05 Re: [PoC] pg_upgrade: allow to upgrade publisher node