| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add inline comments to the pg_hba_file_rules view |
| Date: | 2023-09-10 22:33:16 |
| Message-ID: | ZP5ELFdn28Hn1Hfi@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 04, 2023 at 12:54:15PM +0200, Jim Jones wrote:
> The patch slightly changes the test 004_file_inclusion.pl to accommodate the
> new column and the hba comments.
>
> Discussion: https://www.postgresql.org/message-id/flat/3fec6550-93b0-b542-b203-b0054aaee83b%40uni-muenster.de
Well, it looks like what I wrote a couple of days ago was perhaps
confusing:
https://www.postgresql.org/message-id/ZPHAiNp%2ByKMsa/vc%40paquier.xyz
https://www.postgresql.org/message-id/ZPE8A7EnUH+ax5kw@paquier.xyz
This patch touches hbafuncs.c and the system view pg_hba_file_rules,
but I don't think this stuff should touch any of these code paths.
That's what I meant in my second message: the SQL portion should be
usable for all types of configuration files, even pg_ident.conf and
postgresql.conf, and not only pg_hba.conf. A new SQL function
returning a SRF made of the comments extracted and the line numbers
can be joined with all the system views of the configuration files,
like sourcefile and sourceline in pg_settings, etc.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-09-11 02:05:36 | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Previous Message | Michael Paquier | 2023-09-10 22:24:27 | Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c) |