| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: should frontend tools use syncfs() ? |
| Date: | 2023-08-22 01:50:01 |
| Message-ID: | ZOQUSbi8bD1nhxb4@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 21, 2023 at 06:44:07PM -0700, Nathan Bossart wrote:
> I'm hoping there's a simpler path forward here. pg_rewind only needs the
> following lines from fd.h:
>
> /* Filename components */
> #define PG_TEMP_FILES_DIR "pgsql_tmp"
> #define PG_TEMP_FILE_PREFIX "pgsql_tmp"
>
> Maybe we could move these to file_utils.h instead. WDYT?
I guess so.. At the same time, something can be said about
pg_checksums that redeclares PG_TEMP_FILE_PREFIX and PG_TEMP_FILES_DIR
because it does not want to include fd.h and its sync routines.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-08-22 02:06:32 | Re: should frontend tools use syncfs() ? |
| Previous Message | Peter Smith | 2023-08-22 01:49:09 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |