Re: A Question about InvokeObjectPostAlterHook

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Legs Mansion <1027644833(at)qq(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A Question about InvokeObjectPostAlterHook
Date: 2023-08-15 06:48:23
Message-ID: ZNsft2WTyAaAKLWL@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 18, 2023 at 01:34:00PM +0900, Michael Paquier wrote:
> Note that the development of PostgreSQL 16 has just finished, so now
> may not be the best moment to add these extra AOT calls, but these
> could be added in 17~ for sure at the beginning of July once the next
> development cycle begins.

The OAT hooks are added in ALTER TABLE for the following subcommands:
- { ENABLE | DISABLE | [NO] FORCE } ROW LEVEL SECURITY
- { ENABLE | DISABLE } TRIGGER
- { ENABLE | DISABLE } RULE

> Attached would be what I think would be required to add OATs for RLS,
> triggers and rules, for example. There are much more of these at
> quick glance, still that's one step in providing more checks. Perhaps
> you'd like to expand this patch with more ALTER TABLE subcommands
> covered?

Now that we are at the middle of the development cycle of 17~, it is
time to come back to this one (it was registered in the CF, but I did
not come back to it). Would there be any objections if I apply this
patch with its tests? This would cover most of the ground requested
by Legs at the start of this thread.

(The patch had one diff because of a namespace lookup not happening
anymore, so rebased.)
--
Michael

Attachment Content-Type Size
v2-0001-Add-OAT-calls-for-more-flavors-of-ALTER-TABLE.patch text/x-diff 16.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2023-08-15 06:50:25 Re: Extract numeric filed in JSONB more effectively
Previous Message Michael Paquier 2023-08-15 06:38:06 pg_logical_emit_message() misses a XLogFlush()