Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~
Date: 2023-06-21 02:53:44
Message-ID: ZJJmOH+hIOSoesux@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,
(adding Daniel in CC.)

Compiling Postgres up to 13 with OpenSSL 3.0 leads to a couple of
compilation warnings with what OpenSSL considers as deprecated, like:
sha2_openssl.c: In function pg_sha384_init
sha2_openssl.c:70:9: warning: SHA384_Init is deprecated =
Since OpenSSL 3.0 [-Wdeprecated-declarations]
70 | SHA384_Init((SHA512_CTX *) ctx);
| ^~~~~~~~~~~
/usr/include/openssl/sha.h:119:27: note: declared here
119 | OSSL_DEPRECATEDIN_3_0 int SHA384_Init(SHA512_CTX *c);

I was looking at the code of OpenSSL to see if there would be a way to
silenced these, and found about OPENSSL_SUPPRESS_DEPRECATED.

I have been annoyed by these in the past when doing backpatches, as
this creates some noise, and the only place where this counts is
sha2_openssl.c. Thoughts about doing something like the attached for
~13?
--
Michael

Attachment Content-Type Size
openssl30-warnings-pg13.patch text/x-diff 428 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2023-06-21 02:59:41 Re: Allow pg_archivecleanup to remove backup history files
Previous Message Masahiko Sawada 2023-06-21 02:41:52 Re: Skip collecting decoded changes of already-aborted transactions