From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Evan Jones <evan(dot)jones(at)datadoghq(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific |
Date: | 2023-06-18 23:28:43 |
Message-ID: | ZI+TK2kch0ZZ/Amk@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jun 18, 2023 at 12:38:12PM -0400, Tom Lane wrote:
> FWIW, I think the status quo is fine. Having hstore do something that
> is neither its historical behavior nor aligned with the core parser
> doesn't seem like a great idea.
Okay. Fine by me.
> I don't buy this argument that
> somebody might be depending on the handling of \v in particular. It's
> not any stronger than the argument that they might be depending on,
> say, recognizing no-break space (0xA0) in LATIN1, which the old code
> did (probably, depending on platform) and scanner_isspace will not.
Another thing that I was wondering, though.. Do you think that there
would be an argument in being stricter in the hstore code regarding
the handling of multi-byte characters with some checks based on
IS_HIGHBIT_SET() when parsing the keys and values?
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-06-18 23:31:02 | Re: Deleting prepared statements from libpq. |
Previous Message | Joel Jacobson | 2023-06-18 19:57:57 | Re: Do we want a hashset type? |