From: | Christoph Berg <myon(at)debian(dot)org> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, PostgreSQL Packagers <pgsql-packagers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Move snowball_create.sql creation into perl file |
Date: | 2023-05-23 13:47:46 |
Message-ID: | ZGzEAqjxkkoY3ooH@msg.df7cb.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Re: Andres Freund
> Move snowball_create.sql creation into perl file
>
> This is in preparation for building postgres with meson / ninja.
>
> We already have duplicated code for this between the make and msvc
> builds. Adding a third copy seems like a bad plan, thus move the generation
> into a perl script.
>
> As we don't want to rely on perl being available for builds from tarballs,
> generate the file during distprep.
>
> Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
> Author: Andres Freund <andres(at)anarazel(dot)de>
> Discussion: https://postgr.es/m/5e216522-ba3c-f0e6-7f97-5276d0270029@enterprisedb.com
Hi,
this seems to have broken out-of-tree builds from tarballs:
make -C backend/snowball install
make[3]: Entering directory '/srv/projects/postgresql/debian/16/build/src/backend/snowball'
/bin/mkdir -p '/srv/projects/postgresql/debian/16/build/tmp_install/usr/lib/postgresql/16/lib'
/bin/mkdir -p '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16' '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16/tsearch_data'
/usr/bin/install -c -m 755 dict_snowball.so '/srv/projects/postgresql/debian/16/build/tmp_install/usr/lib/postgresql/16/lib/dict_snowball.so'
/usr/bin/install -c -m 644 snowball_create.sql '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16'
/usr/bin/install: cannot stat 'snowball_create.sql': No such file or directory
make[3]: *** [Makefile:110: install] Error 1
The file is present in src/backend/snowball/ but not in build/src/backend/snowball/:
-rw-r--r-- 1 myon myon 44176 22. Mai 21:20 src/backend/snowball/snowball_create.sql
Christoph
From | Date | Subject | |
---|---|---|---|
Next Message | Christoph Berg | 2023-05-23 14:06:26 | Re: pgsql: Move snowball_create.sql creation into perl file |
Previous Message | Peter Eisentraut | 2023-05-23 13:25:10 | pgsql: Add newline at end of file |
From | Date | Subject | |
---|---|---|---|
Next Message | Christoph Berg | 2023-05-23 14:06:26 | Re: pgsql: Move snowball_create.sql creation into perl file |
Previous Message | Aleksander Alekseev | 2023-05-23 13:41:55 | Re: ResourceOwner refactoring |